diff options
| author |  Ben Kochie <superq@gmail.com>
| 2024-03-11 21:09:09 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-03-11 16:09:09 -0400 |
| commit | 0d6e113f9036596df3e291028ad9ffbbdca9677e (patch) | |
| tree | 5abb58200b7e97d55cf773e6519c7c225d888bf1 /plugin/pkg/proxy/metrics.go | |
| parent | a4cbd95795d4d5cd69ddd6628eb254fade3b6037 (diff) | |
| download | coredns-0d6e113f9036596df3e291028ad9ffbbdca9677e.tar.gz coredns-0d6e113f9036596df3e291028ad9ffbbdca9677e.tar.zst coredns-0d6e113f9036596df3e291028ad9ffbbdca9677e.zip | |
Enable Prometheus native histograms (#6524)
Add a NativeHistogramBucketFactor parameter to the use of
`NewHistogramVec` in order to enable use of Prometheus Native
Histograms.
This will store automatically computed sparse buckets in CoreDNS.
If a compatible Prometeus requests native histograms this data will
returned instead of the static buckets.
The default factor of 1.05 should provide high quality resolution data.
Signed-off-by: SuperQ <superq@gmail.com>
Diffstat (limited to 'plugin/pkg/proxy/metrics.go')
| -rw-r--r-- | plugin/pkg/proxy/metrics.go | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/plugin/pkg/proxy/metrics.go b/plugin/pkg/proxy/metrics.go index e4cae97c3..7def8b7ea 100644 --- a/plugin/pkg/proxy/metrics.go +++ b/plugin/pkg/proxy/metrics.go @@ -10,11 +10,12 @@ import ( // Variables declared for monitoring. var ( requestDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{ - Namespace: plugin.Namespace, - Subsystem: "proxy", - Name: "request_duration_seconds", - Buckets: plugin.TimeBuckets, - Help: "Histogram of the time each request took.", + Namespace: plugin.Namespace, + Subsystem: "proxy", + Name: "request_duration_seconds", + Buckets: plugin.TimeBuckets, + NativeHistogramBucketFactor: plugin.NativeHistogramBucketFactor, + Help: "Histogram of the time each request took.", }, []string{"proxy_name", "to", "rcode"}) healthcheckFailureCount = promauto.NewCounterVec(prometheus.CounterOpts{ |