diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-02-17 19:45:52 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-02-17 19:45:52 +0100 |
| commit | 8cce06cba10c42ce501a57bd3b7d06ca6064d774 (patch) | |
| tree | 8b5058915fe0dc06580c1a81a3f795449e17a508 /plugin/pkg/response/typify.go | |
| parent | 9719a47c1bc0bf0098ee07fd004e4d2d2ee139d9 (diff) | |
| download | coredns-8cce06cba10c42ce501a57bd3b7d06ca6064d774.tar.gz coredns-8cce06cba10c42ce501a57bd3b7d06ca6064d774.tar.zst coredns-8cce06cba10c42ce501a57bd3b7d06ca6064d774.zip | |
Type.extra (#1538)
* Revert "pkg/typify: empty messages are OtherError (#1531)"
This reverts commit fc1d73ffa9ae193c4cfca4adc194ae43f9360dbb.
* plugin/cache: add failsafeTTL
If we can not see what TTL we should put on a message to be cached, use
5 seconds as minimal TTL. We used to apply the maximum TTL to these
messages.
Diffstat (limited to 'plugin/pkg/response/typify.go')
| -rw-r--r-- | plugin/pkg/response/typify.go | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/plugin/pkg/response/typify.go b/plugin/pkg/response/typify.go index a80b6b39f..9faa17d7b 100644 --- a/plugin/pkg/response/typify.go +++ b/plugin/pkg/response/typify.go @@ -55,7 +55,6 @@ func Typify(m *dns.Msg, t time.Time) (Type, *dns.OPT) { if m == nil { return OtherError, nil } - opt := m.IsEdns0() do := false if opt != nil { @@ -77,11 +76,6 @@ func Typify(m *dns.Msg, t time.Time) (Type, *dns.OPT) { } } - if m.Response && len(m.Answer) == 0 && len(m.Ns) == 0 { - // Response with nothing in it, maybe stuff in the additional section, this is not useful. - return OtherError, opt - } - // If our message contains any expired sigs and we care about that, we should return expired if do { if expired := typifyExpired(m, t); expired { |