aboutsummaryrefslogtreecommitdiff
path: root/plugin/pkg
diff options
context:
space:
mode:
authorGravatar Zhizhen He <hezhizhen.yi@gmail.com> 2023-08-10 23:06:48 +0800
committerGravatar GitHub <noreply@github.com> 2023-08-10 11:06:48 -0400
commit2fe5890d8b7fc7801d308dbb51bf29c57ee9a92b (patch)
treef4fbc4794fdd5036a09ed5bb2316d1e5bdb4badb /plugin/pkg
parentc657af467b4d5a81fdd296f0917213db71a3dd6d (diff)
downloadcoredns-2fe5890d8b7fc7801d308dbb51bf29c57ee9a92b.tar.gz
coredns-2fe5890d8b7fc7801d308dbb51bf29c57ee9a92b.tar.zst
coredns-2fe5890d8b7fc7801d308dbb51bf29c57ee9a92b.zip
Fix typos (#6235)
* Fix typos and add todo to fix spelling of dnsutil.MaximumDefaulTTL Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com>
Diffstat (limited to 'plugin/pkg')
-rw-r--r--plugin/pkg/dnsutil/ttl.go1
-rw-r--r--plugin/pkg/log/listener_test.go4
-rw-r--r--plugin/pkg/up/up.go6
3 files changed, 6 insertions, 5 deletions
diff --git a/plugin/pkg/dnsutil/ttl.go b/plugin/pkg/dnsutil/ttl.go
index e2b26526d..c7f423a76 100644
--- a/plugin/pkg/dnsutil/ttl.go
+++ b/plugin/pkg/dnsutil/ttl.go
@@ -48,5 +48,6 @@ const (
// MinimalDefaultTTL is the absolute lowest TTL we use in CoreDNS.
MinimalDefaultTTL = 5 * time.Second
// MaximumDefaulTTL is the maximum TTL was use on RRsets in CoreDNS.
+ // TODO: rename as MaximumDefaultTTL
MaximumDefaulTTL = 1 * time.Hour
)
diff --git a/plugin/pkg/log/listener_test.go b/plugin/pkg/log/listener_test.go
index 0df03b446..452d2b38d 100644
--- a/plugin/pkg/log/listener_test.go
+++ b/plugin/pkg/log/listener_test.go
@@ -11,7 +11,7 @@ func TestRegisterAndDeregisterListener(t *testing.T) {
for _, name := range []string{"listener1", "listener2", "listener1"} {
err := RegisterListener(NewMockListener(name))
if err != nil {
- t.Errorf("RegsiterListener Error %s", err)
+ t.Errorf("RegisterListener Error %s", err)
}
}
if len(ls.listeners) != 2 {
@@ -46,7 +46,7 @@ func testListenersCalled(t *testing.T, listenerNames []string, outputs []string)
for _, name := range listenerNames {
err := RegisterListener(NewMockListener(name))
if err != nil {
- t.Errorf("RegsiterListener Error %s", err)
+ t.Errorf("RegisterListener Error %s", err)
}
}
var f bytes.Buffer
diff --git a/plugin/pkg/up/up.go b/plugin/pkg/up/up.go
index 6f18ffb70..649107f59 100644
--- a/plugin/pkg/up/up.go
+++ b/plugin/pkg/up/up.go
@@ -10,9 +10,9 @@ import (
// Probe is used to run a single Func until it returns true (indicating a target is healthy). If an Func
// is already in progress no new one will be added, i.e. there is always a maximum of 1 checks in flight.
//
-// There is a tradeoff to be made in figuring out quickly that an upstream is healthy and not doing to much work
-// (sending queries) to find that out. Having some kind of exp. backoff here won't help much, because you don't won't
-// to backoff too much. You then also need random queries to be perfomed every so often to quickly detect a working
+// There is a tradeoff to be made in figuring out quickly that an upstream is healthy and not doing much work
+// (sending queries) to find that out. Having some kind of exp. backoff here won't help much, because you don't want
+// to backoff too much. You then also need random queries to be performed every so often to quickly detect a working
// upstream. In the end we just send a query every 0.5 second to check the upstream. This hopefully strikes a balance
// between getting information about the upstream state quickly and not doing too much work. Note that 0.5s is still an
// eternity in DNS, so we may actually want to shorten it.
ow=1'>commitdiff
path: root/integration/bunjs-only-snippets/readdir.js (unfollow)
AgeCommit message (Collapse)AuthorFilesLines
2022-03-22Handle integer sizes greater than i32Gravatar Jarred SUmner 14-74/+142
2022-03-22Linux-specific tweaksGravatar Jarred SUmner 6-43/+52
2022-03-22`Response.file` -> `Bun.file`Gravatar Jarred Sumner 3-72/+65
2022-03-21sendfile worksGravatar Jarred Sumner 7-62/+174
2022-03-21[bun.js] 2/? Implement `Response.file`, sendfile editionGravatar Jarred Sumner 8-161/+506
2022-03-21[bun.js] 1/? Implement `Response.file`Gravatar Jarred Sumner 13-103/+1103