aboutsummaryrefslogtreecommitdiff
path: root/plugin/route53/setup_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2019-07-02 16:23:47 +0100
committerGravatar GitHub <noreply@github.com> 2019-07-02 16:23:47 +0100
commit22c6e3e179303955b62276de4b48293b2e90506c (patch)
tree40d967c0de397ca81d505b3d450d3c59671d9700 /plugin/route53/setup_test.go
parent3a0c7c61532db7f8e4ce79f99129201a79729525 (diff)
downloadcoredns-22c6e3e179303955b62276de4b48293b2e90506c.tar.gz
coredns-22c6e3e179303955b62276de4b48293b2e90506c.tar.zst
coredns-22c6e3e179303955b62276de4b48293b2e90506c.zip
plugins: set upstream unconditionally (#2956)
`upstream` is not needed as a setting; just set if unconditionally and remove all documentation and tests for it. At some point we want remove the hanlding for `upstream` as well and error out on seeing it. Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/route53/setup_test.go')
-rw-r--r--plugin/route53/setup_test.go18
1 files changed, 3 insertions, 15 deletions
diff --git a/plugin/route53/setup_test.go b/plugin/route53/setup_test.go
index 4f40d932f..63591f2f7 100644
--- a/plugin/route53/setup_test.go
+++ b/plugin/route53/setup_test.go
@@ -23,19 +23,13 @@ func TestSetupRoute53(t *testing.T) {
{`route53 example.org:12345678 {
aws_access_key
}`, true},
- {`route53 example.org:12345678 {
- upstream 10.0.0.1
-}`, false},
+ {`route53 example.org:12345678 { }`, false},
- {`route53 example.org:12345678 {
- upstream
-}`, false},
- {`route53 example.org:12345678 {
- wat
+ {`route53 example.org:12345678 { }`, false},
+ {`route53 example.org:12345678 { wat
}`, true},
{`route53 example.org:12345678 {
aws_access_key ACCESS_KEY_ID SEKRIT_ACCESS_KEY
- upstream 1.2.3.4
}`, false},
{`route53 example.org:12345678 {
@@ -43,27 +37,21 @@ func TestSetupRoute53(t *testing.T) {
}`, false},
{`route53 example.org:12345678 {
credentials
- upstream 1.2.3.4
}`, true},
{`route53 example.org:12345678 {
credentials default
- upstream 1.2.3.4
}`, false},
{`route53 example.org:12345678 {
credentials default credentials
- upstream 1.2.3.4
}`, false},
{`route53 example.org:12345678 {
credentials default credentials extra-arg
- upstream 1.2.3.4
}`, true},
{`route53 example.org:12345678 example.org:12345678 {
- upstream 1.2.3.4
}`, true},
{`route53 example.org {
- upstream 1.2.3.4
}`, true},
}