diff options
| author |  Miek Gieben <miek@miek.nl>
| 2020-09-29 10:43:58 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-09-29 10:43:58 +0200 |
| commit | 0cb013657028a559b0e5ebe9fb147989cd925562 (patch) | |
| tree | 53889a780226ab5487e2c1d1292fef739261a6ee /plugin/trace/trace_test.go | |
| parent | a617ef3064cb2bcab03225257c04b35f198173aa (diff) | |
| download | coredns-0cb013657028a559b0e5ebe9fb147989cd925562.tar.gz coredns-0cb013657028a559b0e5ebe9fb147989cd925562.tar.zst coredns-0cb013657028a559b0e5ebe9fb147989cd925562.zip | |
Add proto and remote tags to trace plugin (#4159)
* Add proto and client-ip trace tags
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
* Commit my own suggestion
Signed-off-by: Miek Gieben <miek@miek.nl>
Co-authored-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
Diffstat (limited to 'plugin/trace/trace_test.go')
| -rw-r--r-- | plugin/trace/trace_test.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/plugin/trace/trace_test.go b/plugin/trace/trace_test.go index 9b1105129..e06e3e8ee 100644 --- a/plugin/trace/trace_test.go +++ b/plugin/trace/trace_test.go @@ -88,6 +88,12 @@ func TestTrace(t *testing.T) { if rootSpan.Tag(tagType) != req.Type() { t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagType, req.Type(), rootSpan.Tag(tagType)) } + if rootSpan.Tag(tagProto) != req.Proto() { + t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagProto, req.Proto(), rootSpan.Tag(tagProto)) + } + if rootSpan.Tag(tagRemote) != req.IP() { + t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagRemote, req.IP(), rootSpan.Tag(tagRemote)) + } if rootSpan.Tag(tagRcode) != rcode.ToString(tc.rcode) { t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagRcode, rcode.ToString(tc.rcode), rootSpan.Tag(tagRcode)) } |