diff options
| author |  Francois Tur <ftur@infoblox.com>
| 2018-11-01 15:56:00 -0400 |
|---|---|---|
| committer |  Miek Gieben <miek@miek.nl>
| 2018-11-01 19:56:00 +0000 |
| commit | 05204ef14253de13c18b8442c2b04dd03345d98b (patch) | |
| tree | 1050182126f5c9288e59aeb8aa7275a47935bdea /request/request.go | |
| parent | f5aa6cac67d65357dfa81f39f3ef33e57a376795 (diff) | |
| download | coredns-05204ef14253de13c18b8442c2b04dd03345d98b.tar.gz coredns-05204ef14253de13c18b8442c2b04dd03345d98b.tar.zst coredns-05204ef14253de13c18b8442c2b04dd03345d98b.zip | |
Metrics registered on wrong prometheus registry (#2246)
* - UT on metrics verifying that all plugins of all blocs have their metrics collectors declared
* - fix error msg
* - redirect Registry of metric to the one that handle the listener
- allow duplicate of metrics collector on the same Registry (case of same plugin in 2 blocs listening metrics on the same address)
* - fix change of signature
* - ensure cleaning metrics before starting the test (metrics collectors are global vars .. and re-used by several tests)
* - I think I fixed this test. Ensure correct mn of hits and clean metrics before test.
* - fix typo in error msg - proposed at review
* - fix typo in comment
* - remove ResetMetrics functions
- change a way to test the numeric metrics : get the diff between begin and end of test
* - oops. removing debug logs
Diffstat (limited to 'request/request.go')
0 files changed, 0 insertions, 0 deletions