diff options
author | 2020-10-30 10:27:04 +0100 | |
---|---|---|
committer | 2020-10-30 10:27:04 +0100 | |
commit | c840caf1ef77d8f86ee7d11f644e0d6ea42c469a (patch) | |
tree | 8fd3b097e41d1b04f737acfe92a7e81afe5db201 /test/auto_test.go | |
parent | bc0115d71f15aacc04d9ce9e8ce148b31d151800 (diff) | |
download | coredns-c840caf1ef77d8f86ee7d11f644e0d6ea42c469a.tar.gz coredns-c840caf1ef77d8f86ee7d11f644e0d6ea42c469a.tar.zst coredns-c840caf1ef77d8f86ee7d11f644e0d6ea42c469a.zip |
Speed up testing (#4239)
* Speed up testing
* make notification run in the background, this recudes the test_readme
time from 18s to 0.10s
* reduce time for zone reload
* TestServeDNSConcurrent remove entirely. This took a whopping 58s for
... ? A few minutes staring didn't reveal wth it is actually testing.
Making values smaller revealed race conditions in the tests. Remove
entirely.
* Move many interval values to variables so we can reset them to short
values for the tests.
* test_large_axfr: make the zone smaller. The number used 64K has no
rational, make it 64/10 to speed up.
* TestProxyThreeWay: use client with shorter timeout
A few random tidbits in other tests.
Total time saved: 177s (almost 3m) - which makes it worthwhile again to
run the test locally:
this branch:
~~~
ok github.com/coredns/coredns/test 10.437s
cd plugin; time go t ./...
5,51s user 7,51s system 11,15s elapsed 744%CPU (
~~~
master:
~~~
ok github.com/coredns/coredns/test 35.252s
cd plugin; time go t ./...
157,64s user 15,39s system 50,05s elapsed 345%CPU ()
~~~
tests/ -25s
plugins/ -40s
This brings the total on 20s, and another 10s can be saved by fixing
dnstapio. Moving this to 5s would be even better, but 10s is also nice.
Signed-off-by: Miek Gieben <miek@miek.nl>
* Also 0.01
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'test/auto_test.go')
-rw-r--r-- | test/auto_test.go | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/test/auto_test.go b/test/auto_test.go index 03b290ef8..f7502172f 100644 --- a/test/auto_test.go +++ b/test/auto_test.go @@ -21,7 +21,7 @@ func TestAuto(t *testing.T) { corefile := `org:0 { auto { directory ` + tmpdir + ` db\.(.*) {1} - reload 0.1s + reload 0.01s } }` @@ -46,7 +46,7 @@ func TestAuto(t *testing.T) { t.Fatal(err) } - time.Sleep(150 * time.Millisecond) // wait for it to be picked up + time.Sleep(10 * time.Millisecond) // wait for it to be picked up resp, err = dns.Exchange(m, udp) if err != nil { @@ -59,7 +59,7 @@ func TestAuto(t *testing.T) { // Remove db.example.org again. os.Remove(filepath.Join(tmpdir, "db.example.org")) - time.Sleep(150 * time.Millisecond) // wait for it to be picked up + time.Sleep(10 * time.Millisecond) // wait for it to be picked up resp, err = dns.Exchange(m, udp) if err != nil { t.Fatal("Expected to receive reply, but didn't") @@ -80,7 +80,7 @@ func TestAutoNonExistentZone(t *testing.T) { corefile := `.:0 { auto { directory ` + tmpdir + ` (.*) {1} - reload 1s + reload 0.01s } errors stdout }` @@ -119,7 +119,7 @@ func TestAutoAXFR(t *testing.T) { corefile := `org:0 { auto { directory ` + tmpdir + ` db\.(.*) {1} - reload 0.1s + reload 0.01s } transfer { to * @@ -142,7 +142,7 @@ func TestAutoAXFR(t *testing.T) { t.Fatal(err) } - time.Sleep(150 * time.Millisecond) // wait for it to be picked up + time.Sleep(10 * time.Millisecond) // wait for it to be picked up tr := new(dns.Transfer) m := new(dns.Msg) |