aboutsummaryrefslogtreecommitdiff
path: root/test/file_reload_test.go
diff options
context:
space:
mode:
authorGravatar Steve Greene <sgreene570@gmail.com> 2021-05-11 03:11:20 -0400
committerGravatar GitHub <noreply@github.com> 2021-05-11 09:11:20 +0200
commitfdfc9bcdd24f6861353a41b0cd630c7d82e1f868 (patch)
tree232c7d8ea0268c46fc0a74909b235ee70b0bcb09 /test/file_reload_test.go
parent0a3375e76bba0688ce479bcdb34d4b9ae524a438 (diff)
downloadcoredns-fdfc9bcdd24f6861353a41b0cd630c7d82e1f868.tar.gz
coredns-fdfc9bcdd24f6861353a41b0cd630c7d82e1f868.tar.zst
coredns-fdfc9bcdd24f6861353a41b0cd630c7d82e1f868.zip
test: Fix rare race condition in TestZoneReload (#4617)
The following test failure for `TestZoneReload` can be observed periodically: `file_reload_test.go:58: Expected two RR in answer section got 2` This failure can be consistently reproduced using the following command (on my machine, at least): `( cd test ; go test -v -race -run "TestZoneReload" ./... -count=500)` test/file_reload_test.go: Address a typo in a test failure message. Sleep for double the file reload interval to avoid a rare race condition between test code and the file plugin's reload code, which is presumably a result of the time it takes to actually reload. Signed-off-by: Stephen Greene <sgreene@redhat.com>
Diffstat (limited to 'test/file_reload_test.go')
-rw-r--r--test/file_reload_test.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/file_reload_test.go b/test/file_reload_test.go
index 95cc860bb..69b9af5f6 100644
--- a/test/file_reload_test.go
+++ b/test/file_reload_test.go
@@ -47,7 +47,7 @@ func TestZoneReload(t *testing.T) {
// Remove RR from the Apex
ioutil.WriteFile(name, []byte(exampleOrgUpdated), 0644)
- time.Sleep(10 * time.Millisecond) // reload time
+ time.Sleep(20 * time.Millisecond) // reload time, with some race insurance
resp, err = dns.Exchange(m, udp)
if err != nil {
@@ -55,7 +55,7 @@ func TestZoneReload(t *testing.T) {
}
if len(resp.Answer) != 1 {
- t.Fatalf("Expected two RR in answer section got %d", len(resp.Answer))
+ t.Fatalf("Expected one RR in answer section got %d", len(resp.Answer))
}
}