aboutsummaryrefslogtreecommitdiff
path: root/plugin/kubernetes
diff options
context:
space:
mode:
Diffstat (limited to 'plugin/kubernetes')
-rw-r--r--plugin/kubernetes/setup.go14
-rw-r--r--plugin/kubernetes/setup_reverse_test.go36
2 files changed, 1 insertions, 49 deletions
diff --git a/plugin/kubernetes/setup.go b/plugin/kubernetes/setup.go
index 8b9bd2c42..c85170d9b 100644
--- a/plugin/kubernetes/setup.go
+++ b/plugin/kubernetes/setup.go
@@ -96,19 +96,7 @@ func ParseStanza(c *caddy.Controller) (*Kubernetes, error) {
}
k8s.opts = opts
- zones := c.RemainingArgs()
-
- if len(zones) != 0 {
- k8s.Zones = zones
- for i := 0; i < len(k8s.Zones); i++ {
- k8s.Zones[i] = plugin.Host(k8s.Zones[i]).Normalize()
- }
- } else {
- k8s.Zones = make([]string, len(c.ServerBlockKeys))
- for i := 0; i < len(c.ServerBlockKeys); i++ {
- k8s.Zones[i] = plugin.Host(c.ServerBlockKeys[i]).Normalize()
- }
- }
+ k8s.Zones = plugin.OriginsFromArgsOrServerBlock(c.RemainingArgs(), c.ServerBlockKeys)
k8s.primaryZoneIndex = -1
for i, z := range k8s.Zones {
diff --git a/plugin/kubernetes/setup_reverse_test.go b/plugin/kubernetes/setup_reverse_test.go
deleted file mode 100644
index e9b878319..000000000
--- a/plugin/kubernetes/setup_reverse_test.go
+++ /dev/null
@@ -1,36 +0,0 @@
-package kubernetes
-
-import (
- "testing"
-
- "github.com/coredns/caddy"
-)
-
-func TestKubernetesParseReverseZone(t *testing.T) {
- tests := []struct {
- input string // Corefile data as string
- expectedZones []string // expected count of defined zones.
- }{
- {`kubernetes coredns.local 10.0.0.0/16`, []string{"coredns.local.", "0.10.in-addr.arpa."}},
- {`kubernetes coredns.local 10.0.0.0/17`, []string{"coredns.local.", "0.10.in-addr.arpa."}},
- {`kubernetes coredns.local fd00:77:30::0/110`, []string{"coredns.local.", "0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.3.0.0.7.7.0.0.0.0.d.f.ip6.arpa."}},
- }
-
- for i, tc := range tests {
- c := caddy.NewTestController("dns", tc.input)
- k, err := kubernetesParse(c)
- if err != nil {
- t.Fatalf("Test %d: Expected no error, got %q", i, err)
- }
-
- zl := len(k.Zones)
- if zl != len(tc.expectedZones) {
- t.Errorf("Test %d: Expected kubernetes to be initialized with %d zones, found %d zones", i, len(tc.expectedZones), zl)
- }
- for i, z := range tc.expectedZones {
- if k.Zones[i] != z {
- t.Errorf("Test %d: Expected zones to be %q, got %q", i, z, k.Zones[i])
- }
- }
- }
-}