1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
|
package dnssec
import (
"testing"
"time"
"github.com/coredns/coredns/plugin/test"
"github.com/coredns/coredns/request"
"github.com/miekg/dns"
)
func TestZoneSigningBlackLies(t *testing.T) {
d, rm1, rm2 := newDnssec(t, []string{"miek.nl."})
defer rm1()
defer rm2()
m := testNxdomainMsg()
state := request.Request{Req: m, Zone: "miek.nl."}
m = d.Sign(state, time.Now().UTC(), server)
if !section(m.Ns, 2) {
t.Errorf("Authority section should have 2 sigs")
}
var nsec *dns.NSEC
for _, r := range m.Ns {
if r.Header().Rrtype == dns.TypeNSEC {
nsec = r.(*dns.NSEC)
}
}
if m.Rcode != dns.RcodeSuccess {
t.Errorf("Expected rcode %d, got %d", dns.RcodeSuccess, m.Rcode)
}
if nsec == nil {
t.Fatalf("Expected NSEC, got none")
}
if nsec.Hdr.Name != "ww.miek.nl." {
t.Errorf("Expected %s, got %s", "ww.miek.nl.", nsec.Hdr.Name)
}
if nsec.NextDomain != "\\000.ww.miek.nl." {
t.Errorf("Expected %s, got %s", "\\000.ww.miek.nl.", nsec.NextDomain)
}
}
func TestBlackLiesNoError(t *testing.T) {
d, rm1, rm2 := newDnssec(t, []string{"miek.nl."})
defer rm1()
defer rm2()
m := testSuccessMsg()
state := request.Request{Req: m, Zone: "miek.nl."}
m = d.Sign(state, time.Now().UTC(), server)
if m.Rcode != dns.RcodeSuccess {
t.Errorf("Expected rcode %d, got %d", dns.RcodeSuccess, m.Rcode)
}
if len(m.Answer) != 2 {
t.Errorf("Answer section should have 2 RRs")
}
sig, txt := false, false
for _, rr := range m.Answer {
if _, ok := rr.(*dns.RRSIG); ok {
sig = true
}
if _, ok := rr.(*dns.TXT); ok {
txt = true
}
}
if !sig || !txt {
t.Errorf("Expected RRSIG and TXT in answer section")
}
}
func TestBlackLiesApexNsec(t *testing.T) {
d, rm1, rm2 := newDnssec(t, []string{"miek.nl."})
defer rm1()
defer rm2()
m := testNsecMsg()
m.SetQuestion("miek.nl.", dns.TypeNSEC)
state := request.Request{Req: m, Zone: "miek.nl."}
m = d.Sign(state, time.Now().UTC(), server)
if len(m.Ns) > 0 {
t.Error("Authority section should be empty")
}
if len(m.Answer) != 2 {
t.Errorf("Answer section should have 2 RRs")
}
sig, nsec := false, false
for _, rr := range m.Answer {
if _, ok := rr.(*dns.RRSIG); ok {
sig = true
}
if rnsec, ok := rr.(*dns.NSEC); ok {
nsec = true
var bitpresent uint
for _, typeBit := range rnsec.TypeBitMap {
switch typeBit {
case dns.TypeSOA:
bitpresent |= 4
case dns.TypeNSEC:
bitpresent |= 1
case dns.TypeRRSIG:
bitpresent |= 2
}
}
if bitpresent != 7 {
t.Error("NSEC must have SOA, RRSIG and NSEC in its bitmap")
}
}
}
if !sig || !nsec {
t.Errorf("Expected RRSIG and NSEC in answer section")
}
}
func TestBlackLiesNsec(t *testing.T) {
d, rm1, rm2 := newDnssec(t, []string{"miek.nl."})
defer rm1()
defer rm2()
m := testNsecMsg()
m.SetQuestion("www.miek.nl.", dns.TypeNSEC)
state := request.Request{Req: m, Zone: "miek.nl."}
m = d.Sign(state, time.Now().UTC(), server)
if len(m.Ns) > 0 {
t.Error("Authority section should be empty")
}
if len(m.Answer) != 2 {
t.Errorf("Answer section should have 2 RRs")
}
sig, nsec := false, false
for _, rr := range m.Answer {
if _, ok := rr.(*dns.RRSIG); ok {
sig = true
}
if rnsec, ok := rr.(*dns.NSEC); ok {
nsec = true
var bitpresent uint
for _, typeBit := range rnsec.TypeBitMap {
switch typeBit {
case dns.TypeNSEC:
bitpresent |= 1
case dns.TypeRRSIG:
bitpresent |= 2
}
}
if bitpresent != 3 {
t.Error("NSEC must have RRSIG and NSEC in its bitmap")
}
}
}
if !sig || !nsec {
t.Errorf("Expected RRSIG and NSEC in answer section")
}
}
func TestBlackLiesApexDS(t *testing.T) {
d, rm1, rm2 := newDnssec(t, []string{"miek.nl."})
defer rm1()
defer rm2()
m := testApexDSMsg()
m.SetQuestion("miek.nl.", dns.TypeDS)
state := request.Request{Req: m, Zone: "miek.nl."}
m = d.Sign(state, time.Now().UTC(), server)
if !section(m.Ns, 2) {
t.Errorf("Authority section should have 2 sigs")
}
var nsec *dns.NSEC
for _, r := range m.Ns {
if r.Header().Rrtype == dns.TypeNSEC {
nsec = r.(*dns.NSEC)
}
}
if nsec == nil {
t.Error("Expected NSEC, got none")
} else if correctNsecForDS(nsec) {
t.Error("NSEC DS at the apex zone should cover all apex type.")
}
}
func TestBlackLiesDS(t *testing.T) {
d, rm1, rm2 := newDnssec(t, []string{"miek.nl."})
defer rm1()
defer rm2()
m := testApexDSMsg()
m.SetQuestion("sub.miek.nl.", dns.TypeDS)
state := request.Request{Req: m, Zone: "miek.nl."}
m = d.Sign(state, time.Now().UTC(), server)
if !section(m.Ns, 2) {
t.Errorf("Authority section should have 2 sigs")
}
var nsec *dns.NSEC
for _, r := range m.Ns {
if r.Header().Rrtype == dns.TypeNSEC {
nsec = r.(*dns.NSEC)
}
}
if nsec == nil {
t.Error("Expected NSEC, got none")
} else if !correctNsecForDS(nsec) {
t.Error("NSEC DS should cover delegation type only.")
}
}
func correctNsecForDS(nsec *dns.NSEC) bool {
var bitmask uint
/* Coherent TypeBitMap for NSEC of DS should contain at least:
* {TypeNS, TypeNSEC, TypeRRSIG} and no SOA.
* Any missing type will confuse resolver because
* it will prove that the dns query cannot be a delegation point,
* which will break trust resolution for unsigned delegated domain.
* No SOA is obvious for none apex query.
*/
for _, typeBitmask := range nsec.TypeBitMap {
switch typeBitmask {
case dns.TypeNS:
bitmask |= 1
case dns.TypeNSEC:
bitmask |= 2
case dns.TypeRRSIG:
bitmask |= 4
case dns.TypeSOA:
return false
}
}
return bitmask == 7
}
func testNxdomainMsg() *dns.Msg {
return &dns.Msg{MsgHdr: dns.MsgHdr{Rcode: dns.RcodeNameError},
Question: []dns.Question{{Name: "ww.miek.nl.", Qclass: dns.ClassINET, Qtype: dns.TypeTXT}},
Ns: []dns.RR{test.SOA("miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. 1461471181 14400 3600 604800 14400")},
}
}
func testSuccessMsg() *dns.Msg {
return &dns.Msg{MsgHdr: dns.MsgHdr{Rcode: dns.RcodeSuccess},
Question: []dns.Question{{Name: "www.miek.nl.", Qclass: dns.ClassINET, Qtype: dns.TypeTXT}},
Answer: []dns.RR{test.TXT(`www.miek.nl. 1800 IN TXT "response"`)},
}
}
func testNsecMsg() *dns.Msg {
return &dns.Msg{MsgHdr: dns.MsgHdr{Rcode: dns.RcodeNameError},
Question: []dns.Question{{Name: "www.miek.nl.", Qclass: dns.ClassINET, Qtype: dns.TypeNSEC}},
Ns: []dns.RR{test.SOA("miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. 1461471181 14400 3600 604800 14400")},
}
}
func testApexDSMsg() *dns.Msg {
return &dns.Msg{MsgHdr: dns.MsgHdr{Rcode: dns.RcodeNameError},
Question: []dns.Question{{Name: "miek.nl.", Qclass: dns.ClassINET, Qtype: dns.TypeDS}},
Ns: []dns.RR{test.SOA("miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. 1461471181 14400 3600 604800 14400")},
}
}
|
