diff options
| author |  bors[bot] <26634292+bors[bot]@users.noreply.github.com>
| 2020-04-07 22:20:58 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-04-07 22:20:58 +0000 |
| commit | e30cbd8dd3158812b72b0e958b8e0f0949d80f15 (patch) | |
| tree | d5931e9246b37e90450f65caf0bc33595d2adb06 /cortex-m-rt/src | |
| parent | 3222d51668485401f365891745f4148f10400d2f (diff) | |
| parent | 36033333a4e99983cf58110707ec1e8133c2914b (diff) | |
| download | cortex-m-e30cbd8dd3158812b72b0e958b8e0f0949d80f15.tar.gz cortex-m-e30cbd8dd3158812b72b0e958b8e0f0949d80f15.tar.zst cortex-m-e30cbd8dd3158812b72b0e958b8e0f0949d80f15.zip | |
Merge #262
262: Add testing linker=arm-none-eabi-gcc and MSRV to CI r=therealprof a=adamgreig
Replacing #260.
This PR extends our current tests with `linker=rust-lld` and `linker=arm-none-eabi-ld` to include `linker=arm-none-eabi-gcc`, since those options are all included in our example [`.cargo/config`](https://github.com/rust-embedded/cortex-m-rt/blob/master/.cargo/config). It looks like another linker only adds a handful of seconds to CI, since most time is spent building dependencies once.
It also adds a test with Rust 1.32.0 to the CI as a candidate MSRV. Building with 1.31.0 fails because of the dev-dependency on cortex-m-semihosting 0.3.5:
```
error[E0658]: using the `?` macro Kleene operator for "at most one" repetition is unstable (see issue #48075)
--> /home/adam/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-semihosting-0.3.5/src/macros.rs:111:25
|
111 | ($($val:expr),+ $(,)?) => {
| ^
error: expected `*` or `+`
```
That's just a test error which end users wouldn't experience, so we could consider making 1.31.0 the MSRV and working around the c-m-semihosting issue. I don't know if there are other 1.31.0 issues.
Finally the PR removes the travis check preventing builds on pushes to master. In principle we know that builds to master succeed because bors tests them before pushing, so adding the extra check mostly means we get a well-defined build status from Travis for flags etc. The build times for cortex-m-rt (around 3min overall) are a bit longer than r0 (where we did the same thing), so we could just run a minimal test here instead. I don't think it's a significant overhead given how infrequently we push to master, though.
Co-authored-by: Adam Greig <adam@adamgreig.com>
Diffstat (limited to 'cortex-m-rt/src')
| -rw-r--r-- | cortex-m-rt/src/lib.rs | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/cortex-m-rt/src/lib.rs b/cortex-m-rt/src/lib.rs index 0d62d47..4dabad6 100644 --- a/cortex-m-rt/src/lib.rs +++ b/cortex-m-rt/src/lib.rs @@ -372,6 +372,7 @@ //! [`MaybeUninit`]: https://doc.rust-lang.org/core/mem/union.MaybeUninit.html //! //! ```no_run,edition2018 +//! # extern crate core; //! use core::mem::MaybeUninit; //! //! const STACK_SIZE: usize = 8 * 1024; @@ -388,6 +389,10 @@ //! [attr-entry]: attr.entry.html //! [attr-exception]: attr.exception.html //! [attr-pre_init]: attr.pre_init.html +//! +//! # Minimum Supported Rust Version (MSRV) +//! +//! The MSRV of this release is Rust 1.39.0. // # Developer notes // |