Merge #205

205: Stop using randomized symbol names r=therealprof a=jonas-schievink

It isn't possible to do this by incrementing a global counter, since the expansion order of macros isn't guaranteed and might change between compiler invocations.

Fixes #212
Closes https://github.com/rust-embedded/cortex-m-rt/pull/196
Closes https://github.com/rust-embedded/cortex-m-rt/pull/195

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

1 files changed, 43 insertions, 0 deletions

diff --git a/cortex-m-rt/tests/compile-fail/non-static-resource.rs b/cortex-m-rt/tests/compile-fail/non-static-resource.rs
new file mode 100644
index 0000000..ae009a9
--- /dev/null
+++ b/cortex-m-rt/tests/compile-fail/non-static-resource.rs
@@ -0,0 +1,43 @@
+//! Tests that no `&'static mut` to static mutable resources can be obtained, which would be
+//! unsound.
+//!
+//! Regression test for https://github.com/rust-embedded/cortex-m-rt/issues/212
+
+#![no_std]
+#![no_main]
+
+extern crate cortex_m;
+extern crate cortex_m_rt;
+extern crate panic_halt;
+
+use cortex_m_rt::{entry, exception, interrupt, ExceptionFrame};
+
+#[allow(non_camel_case_types)]
+enum interrupt {
+    UART0,
+}
+
+#[exception]
+fn SVCall() {
+    static mut STAT: u8 = 0;
+
+    let _stat: &'static mut u8 = STAT; //~ ERROR explicit lifetime required in the type of `STAT`
+}
+
+#[interrupt]
+fn UART0() {
+    static mut STAT: u8 = 0;
+
+    let _stat: &'static mut u8 = STAT; //~ ERROR explicit lifetime required in the type of `STAT`
+}
+
+#[entry]
+fn you_died_of_dis_entry() -> ! {
+    static mut STAT: u8 = 0;
+
+    // Allowed. This is sound for the entry point since it is only ever called once, and it makes
+    // resources far more useful.
+    let _stat: &'static mut u8 = STAT;
+
+    loop {}
+}