1 files changed, 63 insertions, 22 deletions

diff --git a/xtask/tests/ci.rs b/xtask/tests/ci.rs
index 48356e4..5b449ba 100644
--- a/xtask/tests/ci.rs
+++ b/xtask/tests/ci.rs
@@ -2,6 +2,9 @@ use std::process::Command;
 use std::{env, str};
 use xtask::{check_blobs, install_targets};
 
+/// List of all compilation targets we support.
+///
+/// This should generally list all of the bare-metal thumb targets starting at thumbv6.
 static TARGETS: &[&str] = &[
     "thumbv6m-none-eabi",
     "thumbv7m-none-eabi",
@@ -12,16 +15,71 @@ static TARGETS: &[&str] = &[
     "thumbv8m.main-none-eabihf",
 ];
 
-fn build(target: &str, features: &[&str]) {
-    println!("building for {} {:?}", target, features);
+fn build(package: &str, target: &str, features: &[&str]) {
+    println!("building {} for {} {:?}", package, target, features);
     let mut cargo = Command::new("cargo");
-    cargo.args(&["build", "--target", target]);
+    cargo.args(&["build", "-p", package, "--target", target]);
     for feat in features {
         cargo.args(&["--features", *feat]);
     }
 
+    // Cargo features don't work right when invoked from the workspace root, so change to the
+    // package's directory when necessary.
+    if package != "cortex-m" {
+        cargo.current_dir(package);
+    }
+
     let status = cargo.status().unwrap();
-    assert!(status.success());
+    assert!(status.success(), "failed to execute: {:?}", cargo);
+}
+
+#[rustfmt::skip]
+static PACKAGE_FEATURES: &[(&str, &[&str])] = &[
+    ("cortex-m", &["inline-asm", "cm7-r0p1"]), // no `linker-plugin-lto` since it's experimental
+    ("cortex-m-semihosting", &["inline-asm", "no-semihosting", "jlink-quirks"]),
+    ("panic-semihosting", &["inline-asm", "exit", "jlink-quirks"]),
+];
+
+fn check_crates_build(is_nightly: bool) {
+    // Build all crates for each supported target.
+    for &target in TARGETS {
+        // Filters crate features, keeping only those that are supported.
+        // Relies on all crates in this repo to use the same convention.
+        let should_use_feature = |feat: &str| {
+            match feat {
+                // This is nightly-only, so don't use it on stable.
+                "inline-asm" => is_nightly,
+                // This only affects thumbv7em targets.
+                "cm7-r0p1" => target.starts_with("thumbv7em"),
+
+                _ => true,
+            }
+        };
+
+        for (package, all_features) in PACKAGE_FEATURES {
+            // Every crate must build with the default feature set.
+            build(package, target, &[]);
+
+            let used_features = &*all_features
+                .iter()
+                .copied()
+                .filter(|feat| should_use_feature(*feat))
+                .collect::<Vec<_>>();
+
+            // (note: we don't test with default features disabled, since we don't use them yet)
+
+            // Every crate must build with each individual feature enabled.
+            for feat in used_features {
+                build(package, target, &[*feat]);
+            }
+
+            // Every crate must build with *all* features enabled.
+            build(package, target, used_features);
+
+            // (technically we should be checking the powerset of all features if we wanted to be
+            // *really* sure, but that takes too much time and isn't very easy to implement)
+        }
+    }
 }
 
 fn main() {
@@ -36,22 +94,5 @@ fn main() {
     let output = Command::new("rustc").arg("-V").output().unwrap();
     let is_nightly = str::from_utf8(&output.stdout).unwrap().contains("nightly");
 
-    // Build `cortex-m` for each supported target.
-    for target in TARGETS {
-        build(*target, &[]);
-
-        if is_nightly {
-            // This may fail when nightly breaks. That's fine, the CI job isn't essential.
-            build(*target, &["inline-asm"]);
-        }
-
-        if target.starts_with("thumbv7em") {
-            // These can target Cortex-M7s, which have an errata workaround.
-            build(*target, &["cm7-r0p1"]);
-
-            if is_nightly {
-                build(*target, &["inline-asm", "cm7-r0p1"]);
-            }
-        }
-    }
+    check_crates_build(is_nightly);
 }