1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
|
#include "colormanager.h"
#include <string>
#include <unordered_set>
#include <vector>
#include "3rd-party/catch.hpp"
#include "confighandlerexception.h"
#include "configparser.h"
using namespace newsboat;
class StylesCollector {
std::map<std::string, std::string> styles;
public:
StylesCollector() = default;
std::function<void(const std::string&, const std::string&)> setter()
{
return [this](const std::string& element, const std::string& style) {
if (this->styles.find(element) != this->styles.cend()) {
throw std::invalid_argument(std::string("Multiple styles for element ") + element);
}
this->styles[element] = style;
};
}
size_t styles_count() const
{
return styles.size();
}
std::string style(const std::string& element) const
{
const auto style = styles.find(element);
if (style != styles.cend()) {
return style->second;
} else {
return {};
}
}
};
TEST_CASE(
"apply_colors() invokes the callback for each element, supplying the element name and its style",
"[ColorManager]")
{
ColorManager c;
StylesCollector collector;
SECTION("By default, the list is empty") {
c.apply_colors(collector.setter());
REQUIRE(collector.styles_count() == 0);
}
SECTION("Each processed action adds corresponding entry to return value") {
c.handle_action("color", {"listnormal", "default", "default"});
c.handle_action("color", {"listfocus_unread", "cyan", "default", "bold", "underline"});
c.handle_action("color", {"background", "red", "yellow"});
c.handle_action("color", {"info", "green", "white", "reverse"});
c.handle_action("color", {"end-of-text-marker", "color123", "default", "dim", "protect"});
c.handle_action("color", {"hint-key", "default", "color2"});
c.handle_action("color", {"hint-description", "color3", "default"});
c.apply_colors(collector.setter());
REQUIRE(collector.styles_count() == 10);
REQUIRE(collector.style("listnormal") == "");
REQUIRE(collector.style("listfocus_unread") == "fg=cyan,attr=bold,attr=underline");
REQUIRE(collector.style("background") == "fg=red,bg=yellow");
REQUIRE(collector.style("info") == "fg=green,bg=white,attr=reverse");
REQUIRE(collector.style("title") == "fg=green,bg=white,attr=reverse");
REQUIRE(collector.style("end-of-text-marker") == "fg=color123,attr=dim,attr=protect");
REQUIRE(collector.style("hint-key") == "bg=color2");
REQUIRE(collector.style("hint-description") == "fg=color3");
// These two weren't set explicitly and fell back to `info`
REQUIRE(collector.style("hint-keys-delimiter") == "fg=green,bg=white,attr=reverse");
REQUIRE(collector.style("hint-separator") == "fg=green,bg=white,attr=reverse");
}
SECTION("For `article` element, two additional elements are emitted") {
c.handle_action("color", {"article", "white", "blue", "reverse"});
c.apply_colors(collector.setter());
REQUIRE(collector.styles_count() == 3);
REQUIRE(collector.style("article") == "fg=white,bg=blue,attr=reverse");
REQUIRE(collector.style("color_bold") == "fg=white,bg=blue,attr=reverse,attr=bold");
REQUIRE(collector.style("color_underline") ==
"fg=white,bg=blue,attr=reverse,attr=underline");
}
}
TEST_CASE("register_commands() registers ColorManager with ConfigParser",
"[ColorManager]")
{
ConfigParser cfg;
ColorManager clr;
StylesCollector collector;
REQUIRE_NOTHROW(clr.register_commands(cfg));
clr.apply_colors(collector.setter());
REQUIRE(collector.styles_count() == 0);
cfg.parse_file("data/config-with-colors");
clr.apply_colors(collector.setter());
REQUIRE(collector.styles_count() == 2);
}
TEST_CASE(
"handle_action() throws ConfigHandlerException if there aren't "
"enough parameters",
"[ColorManager]")
{
ColorManager c;
CHECK_THROWS_AS(c.handle_action("color", {}), ConfigHandlerException);
CHECK_THROWS_AS(
c.handle_action("color", {"one"}), ConfigHandlerException);
CHECK_THROWS_AS(c.handle_action("color", {"one", "two"}),
ConfigHandlerException);
}
TEST_CASE(
"handle_action() throws ConfigHandlerException if foreground color "
"is invalid",
"[ColorManager]")
{
ColorManager c;
const std::vector<std::string> non_colors{
{"awesome", "but", "nonexistent", "colors"}};
for (const auto& color : non_colors) {
CHECK_THROWS_AS(c.handle_action("color",
{"listfocus", color, "default"}),
ConfigHandlerException);
}
}
TEST_CASE(
"handle_action() throws ConfigHandlerException if background color "
"is invalid",
"[ColorManager]")
{
ColorManager c;
const std::vector<std::string> non_colors{
{"awesome", "but", "nonexistent", "colors"}};
for (const auto& color : non_colors) {
CHECK_THROWS_AS(c.handle_action("color",
{"listfocus", "default", color}),
ConfigHandlerException);
}
}
TEST_CASE(
"handle_action() throws ConfigHandlerException if color attribute "
"is invalid",
"[ColorManager]")
{
ColorManager c;
const std::vector<std::string> non_attributes{
{"awesome", "but", "nonexistent", "attributes"}};
for (const auto& attr : non_attributes) {
CHECK_THROWS_AS(c.handle_action("color",
{"listfocus", "red", "red", attr}),
ConfigHandlerException);
}
}
TEST_CASE(
"handle_action() throws ConfigHandlerException if color is applied "
"to non-existent element",
"[ColorManager]")
{
ColorManager c;
const std::vector<std::string> non_elements{
{"awesome", "but", "nonexistent", "elements"}};
for (const auto& element : non_elements) {
CHECK_THROWS_AS(
c.handle_action("color", {element, "red", "green"}),
ConfigHandlerException);
}
}
TEST_CASE(
"handle_action() throws ConfigHandlerException if it's passed a "
"command other than \"color\"",
"[ColorManager]")
{
ColorManager c;
const std::vector<std::string> other_commands{
{"browser", "include", "auto-reload", "ocnews-flag-star"}};
for (const auto& command : other_commands) {
CHECK_THROWS_AS(
c.handle_action(command, {}), ConfigHandlerException);
}
}
TEST_CASE("dump_config() returns everything we put into ColorManager",
"[ColorManager]")
{
ColorManager c;
std::unordered_set<std::string> expected;
std::vector<std::string> config;
// Checks that `expected` contains the same lines as `config` contains,
// and nothing more.
auto equivalent = [&]() -> bool {
std::size_t found = 0;
for (const auto& line : config)
{
if (expected.find(line) == expected.end()) {
return false;
}
found++;
}
return found == expected.size();
};
{
INFO("Empty ColorManager outputs nothing");
c.dump_config(config);
REQUIRE(config.empty());
REQUIRE(equivalent());
}
expected.emplace("color listfocus default red");
c.handle_action("color", {"listfocus", "default", "red"});
config.clear();
c.dump_config(config);
REQUIRE(config.size() == 1);
REQUIRE(equivalent());
expected.emplace("color article green cyan bold");
c.handle_action("color", {"article", "green", "cyan", "bold"});
config.clear();
c.dump_config(config);
REQUIRE(config.size() == 2);
REQUIRE(equivalent());
expected.emplace("color listnormal_unread black yellow underline standout");
c.handle_action("color",
{"listnormal_unread", "black", "yellow", "underline", "standout"});
config.clear();
c.dump_config(config);
REQUIRE(config.size() == 3);
REQUIRE(equivalent());
expected.emplace("color hint-keys-delimiter color5 default dim");
c.handle_action("color", {"hint-keys-delimiter", "color5", "default", "dim"});
config.clear();
c.dump_config(config);
REQUIRE(config.size() == 4);
REQUIRE(equivalent());
expected.emplace("color hint-separator color7 color8");
c.handle_action("color", {"hint-separator", "color7", "color8"});
config.clear();
c.dump_config(config);
REQUIRE(config.size() == 5);
REQUIRE(equivalent());
}
TEST_CASE("If no colors were specified for the "
"`title`/`hint-key`/`hint-keys-delimiter`/`hint-separator`/`hint-description` elements, "
"then use colors from the `info` element (if any)",
"[ColorManager]")
{
const std::vector<std::string> elements {
"title", "hint-key", "hint-keys-delimiter", "hint-separator", "hint-description"};
for (const auto& element : elements) {
DYNAMIC_SECTION("element: " << element) {
ColorManager c;
StylesCollector collector;
SECTION("Element's style can be changed as usual") {
c.handle_action("color", {element, "green", "default", "underline"});
c.apply_colors(collector.setter());
REQUIRE(collector.styles_count() >= 1);
REQUIRE(collector.style(element) == "fg=green,attr=underline");
}
SECTION("Element and `info` don't interfere with each other") {
SECTION("Element's style is set before `info`") {
c.handle_action("color", {element, "blue", "black"});
c.handle_action("color", {"info", "green", "yellow", "bold"});
}
SECTION("Element's style is set after `info`") {
c.handle_action("color", {"info", "green", "yellow", "bold"});
c.handle_action("color", {element, "blue", "black"});
}
c.apply_colors(collector.setter());
REQUIRE(collector.styles_count() >= 2);
REQUIRE(collector.style(element) == "fg=blue,bg=black");
REQUIRE(collector.style("info") == "fg=green,bg=yellow,attr=bold");
}
SECTION("Element inherits the `info` style when available") {
c.handle_action("color", {"info", "red", "magenta", "reverse"});
c.apply_colors(collector.setter());
REQUIRE(collector.styles_count() >= 2);
REQUIRE(collector.style(element) == "fg=red,bg=magenta,attr=reverse");
REQUIRE(collector.style("info") == "fg=red,bg=magenta,attr=reverse");
}
SECTION("Element has no style if there is no style for `info` either") {
c.handle_action("color", {"listnormal", "black", "white"});
c.apply_colors(collector.setter());
REQUIRE(collector.styles_count() >= 1);
REQUIRE(collector.style("listnormal") == "fg=black,bg=white");
REQUIRE(collector.style(element) == "");
REQUIRE(collector.style("info") == "");
}
}
}
}
|