1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
#include "fileurlreader.h"
#include <fstream>
#include <map>
#include <unistd.h>
#include "3rd-party/catch.hpp"
#include "test_helpers/chmod.h"
#include "test_helpers/misc.h"
#include "test_helpers/tempfile.h"
#include "utils.h"
using namespace newsboat;
TEST_CASE("URL reader remembers the file name from which it read the URLs",
"[FileUrlReader]")
{
const std::string url("data/test-urls.txt");
FileUrlReader u(url);
REQUIRE(u.get_source() == url);
u.reload();
REQUIRE(u.get_source() == url);
}
TEST_CASE("URL reader extracts all URLs from the file", "[FileUrlReader]")
{
FileUrlReader u("data/test-urls.txt");
u.reload();
REQUIRE(u.get_urls().size() == 3);
REQUIRE(u.get_urls()[0] == "http://test1.url.cc/feed.xml");
REQUIRE(u.get_urls()[1] == "http://anotherfeed.com/");
REQUIRE(u.get_urls()[2] == "http://onemorefeed.at/feed/");
}
TEST_CASE("URL reader extracts feeds' tags", "[FileUrlReader]")
{
FileUrlReader u("data/test-urls.txt");
u.reload();
REQUIRE(u.get_tags("http://test1.url.cc/feed.xml").size() == 3);
REQUIRE(u.get_tags("http://test1.url.cc/feed.xml")[0] == "~title");
REQUIRE(u.get_tags("http://test1.url.cc/feed.xml")[1] == "tag1");
REQUIRE(u.get_tags("http://test1.url.cc/feed.xml")[2] == "tag2");
REQUIRE(u.get_tags("http://anotherfeed.com/").size() == 0);
REQUIRE(u.get_tags("http://onemorefeed.at/feed/").size() == 3);
REQUIRE(u.get_tags("http://onemorefeed.at/feed/")[0] == "tag1");
REQUIRE(u.get_tags("http://onemorefeed.at/feed/")[1] == "~another title");
REQUIRE(u.get_tags("http://onemorefeed.at/feed/")[2] == "tag3");
}
TEST_CASE("URL reader keeps track of unique tags", "[FileUrlReader]")
{
FileUrlReader u("data/test-urls.txt");
u.reload();
REQUIRE(u.get_alltags().size() == 3);
}
TEST_CASE("URL reader writes files that it can understand later",
"[FileUrlReader]")
{
const std::string testDataPath("data/test-urls.txt");
test_helpers::TempFile urlsFile;
test_helpers::copy_file(testDataPath, urlsFile.get_path());
FileUrlReader u(urlsFile.get_path());
u.reload();
REQUIRE_FALSE(u.get_urls().empty());
REQUIRE_FALSE(u.get_alltags().empty());
std::ofstream urlsFileStream(urlsFile.get_path());
REQUIRE(urlsFileStream.is_open());
urlsFileStream << std::string();
urlsFileStream.close();
u.write_config();
FileUrlReader u2(urlsFile.get_path());
u2.reload();
REQUIRE_FALSE(u2.get_urls().empty());
REQUIRE_FALSE(u2.get_alltags().empty());
REQUIRE(u.get_alltags() == u2.get_alltags());
REQUIRE(u.get_urls() == u2.get_urls());
for (const auto& url : u.get_urls()) {
REQUIRE(u.get_tags(url) == u2.get_tags(url));
}
}
TEST_CASE("Preserves URLs as-is", "[FileUrlReader][issue926]")
{
const std::string testDataPath("data/926-urls");
FileUrlReader u(testDataPath);
u.reload();
REQUIRE(u.get_urls().size() == 1);
REQUIRE(u.get_urls()[0] ==
R"_(exec:curl --silent https://feeds.metaebene.me/raumzeit/m4a | sed 's#\(</guid>\|</id>\)#-M4A&#')_");
}
TEST_CASE("URL reader returns error structure if file cannot be opened",
"[FileUrlReader]")
{
const std::string testDataPath("data/test-urls.txt");
test_helpers::TempFile urlsFile;
FileUrlReader u(urlsFile.get_path());
SECTION("reload() returns error structure if file does not exist") {
const auto error_message = u.reload();
REQUIRE(error_message.has_value());
SECTION("the error structure contains error message and kind of an error") {
INFO("error_message: " + error_message.value().message);
REQUIRE_FALSE(error_message.value().message.empty());
}
}
SECTION("write_config() works fine if file does not exist") {
const auto error_message = u.write_config();
REQUIRE_FALSE(error_message.has_value());
SECTION("after writing file, reload() succeeds") {
const auto error_message = u.reload();
REQUIRE_FALSE(error_message.has_value());
}
}
test_helpers::copy_file(testDataPath, urlsFile.get_path());
SECTION("reload() succeeds if url file exists") {
const auto error_message = u.reload();
REQUIRE_FALSE(error_message.has_value());
}
GIVEN("that the urls file is not readable") {
test_helpers::Chmod notReadable(urlsFile.get_path(), S_IWUSR);
THEN("reload() returns an error message") {
const auto error_message = u.reload();
REQUIRE(error_message.has_value());
}
THEN("write_config() still works fine") {
const auto error_message = u.write_config();
REQUIRE_FALSE(error_message.has_value());
}
}
GIVEN("that the urls file is not writable") {
test_helpers::Chmod notWritable(urlsFile.get_path(), S_IRUSR);
THEN("write_config() returns an error message") {
const auto error_message = u.write_config();
REQUIRE(error_message.has_value());
SECTION("the error message contains the filename") {
INFO("error_message: " + error_message.value());
REQUIRE(error_message.value().find(urlsFile.get_path()) != std::string::npos);
}
}
THEN("reload() still work fine") {
const auto error_message = u.reload();
REQUIRE_FALSE(error_message.has_value());
}
}
}
TEST_CASE("URL reader returns error message if file contains invalid UTF-8 codepoint",
"[FileUrlReader]")
{
test_helpers::TempFile urlsFile;
{
std::ofstream f(urlsFile.get_path());
f << "http://exmample.com/atom.xml" << std::endl;
f << "http://invalid.com/\xff.xml" << std::endl;
}
FileUrlReader u(urlsFile.get_path());
auto error_message = u.reload();
REQUIRE(error_message.has_value());
REQUIRE(error_message.value().message.size() > 0);
}
TEST_CASE("FileUrlReader::get_alltags() returns all unique tags across all feeds, "
"excluding the title tags",
"[FileUrlReader]")
{
FileUrlReader u("data/test-urls.txt");
u.reload();
const auto tags = u.get_alltags();
REQUIRE(tags.size() == 3);
REQUIRE(tags[0] == "tag1");
REQUIRE(tags[1] == "tag2");
REQUIRE(tags[2] == "tag3");
}
|
