diff options
author | 2023-04-26 21:02:00 +0800 | |
---|---|---|
committer | 2023-04-26 21:02:00 +0800 | |
commit | 841b0f8cc06f41d05faefe80b314689785c4779b (patch) | |
tree | 032ca29503bab1eed29439657f25a059f1774d99 | |
parent | b128db06a6fc3cdc88745ee21ca5b9c414db99e8 (diff) | |
download | refined-github-841b0f8cc06f41d05faefe80b314689785c4779b.tar.gz refined-github-841b0f8cc06f41d05faefe80b314689785c4779b.tar.zst refined-github-841b0f8cc06f41d05faefe80b314689785c4779b.zip |
Avoid race conditions in PR merge commit fields (#6584)23.4.26
-rw-r--r-- | source/features/clear-pr-merge-commit-message.tsx | 4 | ||||
-rw-r--r-- | source/features/sync-pr-commit-title.tsx | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/source/features/clear-pr-merge-commit-message.tsx b/source/features/clear-pr-merge-commit-message.tsx index efa2b4ea..d49ba175 100644 --- a/source/features/clear-pr-merge-commit-message.tsx +++ b/source/features/clear-pr-merge-commit-message.tsx @@ -1,6 +1,5 @@ import React from 'dom-chef'; import select from 'select-dom'; -import {set} from 'text-field-edit'; import * as pageDetect from 'github-url-detection'; import features from '../feature-manager'; @@ -23,7 +22,8 @@ async function clear(messageField: HTMLTextAreaElement): Promise<void | false> { return false; } - set(messageField, cleanedMessage ? cleanedMessage + '\n' : ''); + // Do not use `text-field-edit` #6348 + messageField.value = cleanedMessage ? cleanedMessage + '\n' : ''; messageField.after( <div> <p className="note"> diff --git a/source/features/sync-pr-commit-title.tsx b/source/features/sync-pr-commit-title.tsx index 36aa04d1..80116198 100644 --- a/source/features/sync-pr-commit-title.tsx +++ b/source/features/sync-pr-commit-title.tsx @@ -2,7 +2,6 @@ import React from 'dom-chef'; import select from 'select-dom'; import delegate from 'delegate-it'; import * as pageDetect from 'github-url-detection'; -import * as textFieldEdit from 'text-field-edit'; import * as api from '../github-helpers/api'; import features from '../feature-manager'; @@ -66,7 +65,8 @@ async function updatePRTitle(): Promise<void> { async function updateCommitTitle(): Promise<void> { const field = getCurrentCommitTitleField()!; if (field) { - textFieldEdit.set(field, createCommitTitle()); + // Do not use `text-field-edit` #6348 + field.value = createCommitTitle(); } } |