1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
|
import './conversation-activity-filter.css';
import delay from 'delay';
import React from 'dom-chef';
import {$, $$, elementExists} from 'select-dom';
import * as pageDetect from 'github-url-detection';
import {CheckIcon, EyeClosedIcon, EyeIcon, XIcon} from '@primer/octicons-react';
import {wrap} from '../helpers/dom-utils.js';
import features from '../feature-manager.js';
import {registerHotkey} from '../github-helpers/hotkey.js';
import observe from '../helpers/selector-observer.js';
const expectedDropdownWidth = 270;
const states = {
default: '',
hideEvents: 'Hide events',
hideEventsAndCollapsedComments: 'Hide events and collapsed comments',
};
type State = keyof typeof states;
const dropdownClass = 'rgh-conversation-activity-filter-dropdown';
const hiddenClassName = 'rgh-conversation-activity-filtered';
const collapsedClassName = 'rgh-conversation-activity-collapsed';
function processTimelineEvent(item: HTMLElement): void {
// Don't hide commits in PR conversation timelines #5581
if (pageDetect.isPR() && elementExists('.TimelineItem-badge .octicon-git-commit', item)) {
return;
}
item.classList.add(hiddenClassName);
}
function processSimpleComment(item: HTMLElement): void {
// Hide comments marked as resolved/hidden
if (elementExists('.minimized-comment > details', item)) {
item.classList.add(collapsedClassName);
}
}
function processDissmissedReviewEvent(item: HTMLElement): void {
item.classList.add(hiddenClassName);
// Find and hide stale reviews referenced by dismissed review events
for (const {hash: staleReviewId} of $$('.TimelineItem-body > a[href^="#pullrequestreview-"]', item)) {
$(staleReviewId)!
.closest('.js-timeline-item')!
.classList.add(collapsedClassName);
}
}
function processReview(review: HTMLElement): void {
const hasMainComment = elementExists('.js-comment[id^=pullrequestreview] .timeline-comment', review);
// Don't combine the selectors or use early returns without understanding what a thread or thread comment is
const unresolvedThreads = $$('.js-resolvable-timeline-thread-container[data-resolved="false"]', review);
const unresolvedThreadComments = $$('.timeline-comment-group:not(.minimized-comment)', review);
if (!hasMainComment && (unresolvedThreads.length === 0 || unresolvedThreadComments.length === 0)) {
review.classList.add(collapsedClassName); // The whole review is essentially resolved
return;
}
for (const thread of unresolvedThreads) {
// Hide threads containing only resolved comments
if (!unresolvedThreadComments.some(comment => thread.contains(comment))) {
thread.classList.add(collapsedClassName);
}
}
}
function processItem(item: HTMLElement): void {
// Exclude deep-linked comment
if (location.hash.startsWith('#issuecomment-') && elementExists(location.hash, item)) {
return;
}
if (elementExists('.js-comment[id^=pullrequestreview]', item)) {
processReview(item);
} else if (elementExists('.TimelineItem-badge .octicon-x', item)) {
processDissmissedReviewEvent(item);
} else if (elementExists('.comment-body', item)) {
processSimpleComment(item);
} else {
processTimelineEvent(item);
}
}
async function handleSelection({target}: Event): Promise<void> {
// The event is fired before the DOM is updated. Extensions can't access the event’s `detail` where the widget would normally specify which element was selected
await delay(1);
const state = $('[aria-checked="true"]', target as Element)!.dataset.value as State;
applyState(state);
}
function applyState(state: State): void {
const container = $('.js-issues-results')!;
container.classList.toggle(
'rgh-conversation-activity-is-filtered',
state !== 'default',
);
container.classList.toggle(
'rgh-conversation-activity-is-collapsed-filtered',
state === 'hideEventsAndCollapsedComments',
);
// Update the state of the dropdowns
for (const dropdownItem of $$(`.${dropdownClass} [aria-checked="false"][data-value="${state}"]`)) {
dropdownItem.setAttribute('aria-checked', 'true');
}
for (const dropdownItem of $$(`.${dropdownClass} [aria-checked="true"]:not([data-value="${state}"])`)) {
dropdownItem.setAttribute('aria-checked', 'false');
}
}
function createRadios(current: State): JSX.Element[] {
return Object.entries(states).map(([state, label]) => (
<div
className="SelectMenu-item"
role="menuitemradio"
aria-checked={state === current ? 'true' : 'false'}
data-value={state}
>
<CheckIcon className="SelectMenu-icon SelectMenu-icon--check"/>
{label || 'Show all'}
</div>
));
}
async function addWidget(state: State, anchor: HTMLElement): Promise<void> {
// TODO: use :has instead
const position = anchor.closest('div')!;
if (position.classList.contains('rgh-conversation-activity-filter')) {
return;
}
// Try to place the dropdown to the left https://github.com/refined-github/refined-github/issues/5450#issuecomment-1068284635
const availableSpaceToTheLeftOfTheDropdown
= position.lastElementChild!.getBoundingClientRect().right
- position.parentElement!.getBoundingClientRect().left;
// It may be zero on the sticky header, but `clean-conversation-headers` doesn't apply there
const alignment
= availableSpaceToTheLeftOfTheDropdown === 0
|| (availableSpaceToTheLeftOfTheDropdown > expectedDropdownWidth)
? 'right-0' : 'left-0';
wrap(position, <div className="rgh-conversation-activity-filter-wrapper"/>);
position.classList.add('rgh-conversation-activity-filter');
position.after(
<details
className={`details-reset details-overlay d-inline-block ml-2 position-relative ${dropdownClass}`}
id="rgh-conversation-activity-filter-select-menu"
>
<summary>
<EyeIcon className="color-fg-muted"/>
<EyeClosedIcon className="color-fg-danger"/>
<div className="dropdown-caret ml-1"/>
</summary>
<details-menu
className={`SelectMenu ${alignment}`}
on-details-menu-select={handleSelection}
>
<div className="SelectMenu-modal">
<div className="SelectMenu-header">
<h3 className="SelectMenu-title color-fg-default">
Filter conversation activities
</h3>
<button
className="SelectMenu-closeButton"
type="button"
data-toggle-for="rgh-conversation-activity-filter-select-menu"
>
<XIcon/>
</button>
</div>
<div className="SelectMenu-list">
{createRadios(state)}
</div>
</div>
</details-menu>
</details>,
);
}
const minorFixesIssuePages = [
'https://github.com/refined-github/refined-github/issues/3686',
'https://github.com/refined-github/refined-github/issues/6000',
];
function uncollapseTargetedComment(): void {
if (location.hash.startsWith('#issuecomment-')) {
$(`.${collapsedClassName} ${location.hash}`)?.closest('.js-timeline-item')?.classList.remove(collapsedClassName);
}
}
function switchToNextFilter(): void {
const state = $(`.${dropdownClass} [aria-checked="true"]`)!.dataset.value as State;
// eslint-disable-next-line default-case
switch (state) {
case 'default': {
applyState('hideEvents');
break;
}
case 'hideEvents': {
applyState('hideEventsAndCollapsedComments');
break;
}
case 'hideEventsAndCollapsedComments': {
applyState('default');
break;
}
}
}
async function init(signal: AbortSignal): Promise<void> {
const initialState = minorFixesIssuePages.some(url => location.href.startsWith(url))
? 'hideEventsAndCollapsedComments' // Automatically hide resolved comments on "Minor codebase updates and fixes" issue pages
: 'default';
observe([
'#partial-discussion-header .gh-header-meta :is(clipboard-copy, .flex-auto)',
'#partial-discussion-header .gh-header-sticky :is(clipboard-copy, relative-time)',
], addWidget.bind(null, initialState), {signal});
if (initialState !== 'default') {
applyState(initialState);
}
window.addEventListener('hashchange', uncollapseTargetedComment, {signal});
observe('.js-timeline-item', processItem, {signal});
registerHotkey('h', switchToNextFilter, {signal});
}
void features.add(import.meta.url, {
include: [
pageDetect.isConversation,
],
shortcuts: {
h: 'Cycle through conversation activity filters',
},
init,
});
/*
Test URLs:
https://github.com/refined-github/refined-github/pull/4030
https://github.com/refined-github/refined-github/issues/4008
*/
|