1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
import React from 'dom-chef';
import select from 'select-dom';
import delegate from 'delegate-it';
import features from '../libs/features';
function init(): false | void {
const form = select('[action$="/reviews"]')!;
const radios = select.all<HTMLInputElement>('[type="radio"][name="pull_request_review[event]"]', form);
if (radios.length === 0) {
return false;
}
const container = select('.form-actions', form)!;
// Set the default action for cmd+enter to Comment
if (radios.length > 1) {
container.append(
<input
type="hidden"
name="pull_request_review[event]"
value="comment"/>
);
}
// Generate the new buttons
for (const radio of radios) {
const tooltip = radio.parentElement!.getAttribute('aria-label');
const classes = ['btn btn-sm'];
if (radio.value === 'approve') {
classes.push('btn-primary');
} else if (radio.value === 'reject') {
classes.push('btn-danger');
}
if (tooltip) {
classes.push('tooltipped tooltipped-nw tooltipped-no-delay');
}
container.append(
<button
name="pull_request_review[event]"
value={radio.value}
className={classes.join(' ')}
aria-label={tooltip ?? undefined}
disabled={radio.disabled}>
{radio.nextSibling}
</button>
);
}
// Comment button must be last; cancel button must be first
if (radios.length > 1) {
container.append(select('button[value="comment"]', form)!);
const cancelReview = select('.review-cancel-button', form);
if (cancelReview) {
cancelReview.classList.add('float-left');
container.prepend(cancelReview);
}
}
// Remove original fields at last to avoid leaving a broken form
for (const radio of radios) {
radio.closest('.form-checkbox')!.remove();
}
select('[type="submit"]:not([name])', form)!.remove(); // The selector excludes the "Cancel" button
// This will prevent submission when clicking "Comment" and "Request changes" without entering a comment and no other review comments are pending
delegate<HTMLButtonElement>(form, 'button', 'click', ({delegateTarget: {value}}) => {
const submissionRequiresComment = !select.exists('.is-review-pending') && (value === 'reject' || value === 'comment');
select('#pull_request_review_body', form)!.toggleAttribute('required', submissionRequiresComment);
});
// Freeze form to avoid duplicate submissions
form.addEventListener('submit', () => {
// Delay disabling the fields to let them be submitted first
setTimeout(() => {
for (const control of select.all<HTMLButtonElement | HTMLTextAreaElement>('button, textarea', form)) {
control.disabled = true;
}
});
});
}
features.add({
id: __featureName__,
description: 'Simplifies the PR review form: Approve or reject reviews faster with one-click review-type buttons.',
screenshot: 'https://user-images.githubusercontent.com/1402241/34326942-529cb7c0-e8f3-11e7-9bee-98b667e18a90.png',
include: [
features.isPR
],
load: features.onAjaxedPages,
init
});
|
