Merge #730

730: remove vis restriction for local and shared resources r=korken89 a=andrewgazelka



Co-authored-by: Andrew Gazelka <andrew.gazelka@gmail.com>

1 files changed, 5 insertions, 18 deletions

diff --git a/rtic-macros/src/syntax/parse/resource.rs b/rtic-macros/src/syntax/parse/resource.rs
index ff100576..9ce67253 100644
--- a/rtic-macros/src/syntax/parse/resource.rs
+++ b/rtic-macros/src/syntax/parse/resource.rs
@@ -1,5 +1,4 @@
-use proc_macro2::Span;
-use syn::{parse, Field, Visibility};
+use syn::{parse, Field};
 
 use crate::syntax::parse::util::FilterAttrs;
 use crate::syntax::{
@@ -8,14 +7,7 @@ use crate::syntax::{
 };
 
 impl SharedResource {
-    pub(crate) fn parse(item: &Field, span: Span) -> parse::Result<Self> {
-        if item.vis != Visibility::Inherited {
-            return Err(parse::Error::new(
-                span,
-                "this field must have inherited / private visibility",
-            ));
-        }
-
+    pub(crate) fn parse(item: &Field) -> parse::Result<Self> {
         let FilterAttrs {
             cfgs,
             mut attrs,
@@ -30,19 +22,13 @@ impl SharedResource {
             docs,
             ty: Box::new(item.ty.clone()),
             properties: SharedResourceProperties { lock_free },
+            vis: item.vis.clone(),
         })
     }
 }
 
 impl LocalResource {
-    pub(crate) fn parse(item: &Field, span: Span) -> parse::Result<Self> {
-        if item.vis != Visibility::Inherited {
-            return Err(parse::Error::new(
-                span,
-                "this field must have inherited / private visibility",
-            ));
-        }
-
+    pub(crate) fn parse(item: &Field) -> parse::Result<Self> {
         let FilterAttrs { cfgs, attrs, docs } = util::filter_attributes(item.attrs.clone());
 
         Ok(LocalResource {
@@ -50,6 +36,7 @@ impl LocalResource {
             attrs,
             docs,
             ty: Box::new(item.ty.clone()),
+            vis: item.vis.clone(),
         })
     }
 }