aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar jvoisin <julien.voisin@dustri.org> 2024-03-11 00:20:55 +0100
committerGravatar Frédéric Guillot <f@miniflux.net> 2024-03-11 15:03:00 -0700
commitfd1fee852cb35fa0f5b0ed6dc0c23b4a6ce368c3 (patch)
treecbd3d8b14eb7f5f3f38f2d518765bd30ea2d44e9
parentc51a3270da1f6af796b7d23fa4b434ccf11818e7 (diff)
downloadv2-fd1fee852cb35fa0f5b0ed6dc0c23b4a6ce368c3.tar.gz
v2-fd1fee852cb35fa0f5b0ed6dc0c23b4a6ce368c3.tar.zst
v2-fd1fee852cb35fa0f5b0ed6dc0c23b4a6ce368c3.zip
Simplify DomHelper.getVisibleElements
Use a `filter` instead of a loop with an index.
-rw-r--r--internal/ui/static/js/dom_helper.js12
1 files changed, 2 insertions, 10 deletions
diff --git a/internal/ui/static/js/dom_helper.js b/internal/ui/static/js/dom_helper.js
index fe0afcac..352d6b03 100644
--- a/internal/ui/static/js/dom_helper.js
+++ b/internal/ui/static/js/dom_helper.js
@@ -22,16 +22,8 @@ class DomHelper {
}
static getVisibleElements(selector) {
- let elements = document.querySelectorAll(selector);
- let result = [];
-
- for (let i = 0; i < elements.length; i++) {
- if (this.isVisible(elements[i])) {
- result.push(elements[i]);
- }
- }
-
- return result;
+ const elements = document.querySelectorAll(selector);
+ return [...elements].filter((element) => this.isVisible(element));
}
static hasPassiveEventListenerOption() {