diff options
| author |  jvoisin <julien.voisin@dustri.org>
| 2024-03-04 00:32:16 +0100 |
|---|---|---|
| committer |  Frédéric Guillot <f@miniflux.net>
| 2024-03-03 20:32:15 -0800 |
| commit | 8d80e9103f836284b73bc8d176c5ca63c31b0dfc (patch) | |
| tree | be76d5d8f02499dfda0831616cfbc69ee8c336c1 /internal/ui/settings_update.go | |
| parent | d55b41080062915e728b6afb75f5623927f100f7 (diff) | |
| download | v2-8d80e9103f836284b73bc8d176c5ca63c31b0dfc.tar.gz v2-8d80e9103f836284b73bc8d176c5ca63c31b0dfc.tar.zst v2-8d80e9103f836284b73bc8d176c5ca63c31b0dfc.zip | |
Delay call of `view.New` after logging the user in
There is no need to do extra work like creating a session and its associated
view until the user has been properly identified and as many possibly-failing sql request have been successfully run.
Diffstat (limited to 'internal/ui/settings_update.go')
| -rw-r--r-- | internal/ui/settings_update.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/internal/ui/settings_update.go b/internal/ui/settings_update.go index d580e8d7..122ad441 100644 --- a/internal/ui/settings_update.go +++ b/internal/ui/settings_update.go @@ -18,9 +18,6 @@ import ( ) func (h *handler) updateSettings(w http.ResponseWriter, r *http.Request) { - sess := session.New(h.store, request.SessionID(r)) - view := view.New(h.tpl, r, sess) - loggedUser, err := h.store.UserByID(request.UserID(r)) if err != nil { html.ServerError(w, r, err) @@ -35,6 +32,8 @@ func (h *handler) updateSettings(w http.ResponseWriter, r *http.Request) { settingsForm := form.NewSettingsForm(r) + sess := session.New(h.store, request.SessionID(r)) + view := view.New(h.tpl, r, sess) view.Set("form", settingsForm) view.Set("themes", model.Themes()) view.Set("languages", locale.AvailableLanguages()) |