aboutsummaryrefslogtreecommitdiff
path: root/middleware/kubernetes/kubernetes_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2017-08-05 12:29:43 -0700
committerGravatar GitHub <noreply@github.com> 2017-08-05 12:29:43 -0700
commitc84df38ac59b0448e15cf85306e7ec10cd7ab155 (patch)
treebd07181d31dd2f51ea03d728bc3704385fbf7005 /middleware/kubernetes/kubernetes_test.go
parenta235833be8b77cfa5a7a6be033c383f74066b794 (diff)
downloadcoredns-c84df38ac59b0448e15cf85306e7ec10cd7ab155.tar.gz
coredns-c84df38ac59b0448e15cf85306e7ec10cd7ab155.tar.zst
coredns-c84df38ac59b0448e15cf85306e7ec10cd7ab155.zip
middleware/kubernetes: fixes (#837)
dedent code, use shorter names. use strings.EqualFold instead ToLower to avoid create garbage.
Diffstat (limited to 'middleware/kubernetes/kubernetes_test.go')
-rw-r--r--middleware/kubernetes/kubernetes_test.go14
1 files changed, 7 insertions, 7 deletions
diff --git a/middleware/kubernetes/kubernetes_test.go b/middleware/kubernetes/kubernetes_test.go
index 3323ff893..268028c1e 100644
--- a/middleware/kubernetes/kubernetes_test.go
+++ b/middleware/kubernetes/kubernetes_test.go
@@ -78,9 +78,9 @@ func TestIsNameError(t *testing.T) {
}
func TestSymbolContainsWildcard(t *testing.T) {
- var testdataSymbolContainsWildcard = []struct {
- Symbol string
- ExpectedResult bool
+ var tests = []struct {
+ s string
+ expected bool
}{
{"mynamespace", false},
{"*", true},
@@ -90,10 +90,10 @@ func TestSymbolContainsWildcard(t *testing.T) {
{"myname*", false},
}
- for _, example := range testdataSymbolContainsWildcard {
- actualResult := symbolContainsWildcard(example.Symbol)
- if actualResult != example.ExpectedResult {
- t.Errorf("Expected SymbolContainsWildcard result '%v' for example string='%v'. Instead got result '%v'.", example.ExpectedResult, example.Symbol, actualResult)
+ for _, te := range tests {
+ got := wildcard(te.s)
+ if got != te.expected {
+ t.Errorf("Expected Wildcard result '%v' for example '%v', got '%v'.", te.expected, te.s, got)
}
}
}