diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-02-16 09:43:22 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-02-16 09:43:22 +0100 |
| commit | fc1d73ffa9ae193c4cfca4adc194ae43f9360dbb (patch) | |
| tree | ec08dd8896a2b0e1d73f88aabae6310c67b02fa6 /plugin/cache/cache.go | |
| parent | f10627c1d61518b33c658db64c8b8b1bc6a914cb (diff) | |
| download | coredns-fc1d73ffa9ae193c4cfca4adc194ae43f9360dbb.tar.gz coredns-fc1d73ffa9ae193c4cfca4adc194ae43f9360dbb.tar.zst coredns-fc1d73ffa9ae193c4cfca4adc194ae43f9360dbb.zip | |
pkg/typify: empty messages are OtherError (#1531)
Messages with nothing in them are considered OtherError, they can not
serve any purpose for normal clients (i.e. dyn update or notifies might
have a use for them).
Also update a test in the cache plugin, so that we explicitaly test for
this case.
Diffstat (limited to 'plugin/cache/cache.go')
| -rw-r--r-- | plugin/cache/cache.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugin/cache/cache.go b/plugin/cache/cache.go index cb7a10140..2967e1b34 100644 --- a/plugin/cache/cache.go +++ b/plugin/cache/cache.go @@ -171,7 +171,7 @@ func (w *ResponseWriter) set(m *dns.Msg, key int, mt response.Type, duration tim case response.OtherError: // don't cache these default: - log.Printf("[WARNING] Caching called with unknown classification: %d", mt) + log.Printf("[WARNING] Caching called with unknown typification: %d", mt) } } |