aboutsummaryrefslogtreecommitdiff
path: root/plugin/kubernetes/federation.go
diff options
context:
space:
mode:
authorGravatar Chris O'Haver <cohaver@infoblox.com> 2018-09-12 02:07:24 -0400
committerGravatar Miek Gieben <miek@miek.nl> 2018-09-12 07:07:24 +0100
commit0bf8b81cb7a5894e7cb6336ac5a8f7510c92692d (patch)
tree6c837b36b2eb65133ac82d34399db35ba11903a5 /plugin/kubernetes/federation.go
parentb42eae7a04b8f789d7a20c0664895cd8e4638a22 (diff)
downloadcoredns-0bf8b81cb7a5894e7cb6336ac5a8f7510c92692d.tar.gz
coredns-0bf8b81cb7a5894e7cb6336ac5a8f7510c92692d.tar.zst
coredns-0bf8b81cb7a5894e7cb6336ac5a8f7510c92692d.zip
plugin/federation: handle missing avail-zone/region labels better (#2092)
* handle missing avail-zone/region labels better * oops forgot a file
Diffstat (limited to 'plugin/kubernetes/federation.go')
-rw-r--r--plugin/kubernetes/federation.go6
1 files changed, 6 insertions, 0 deletions
diff --git a/plugin/kubernetes/federation.go b/plugin/kubernetes/federation.go
index df6ae948b..78e31668b 100644
--- a/plugin/kubernetes/federation.go
+++ b/plugin/kubernetes/federation.go
@@ -1,6 +1,8 @@
package kubernetes
import (
+ "errors"
+
"github.com/coredns/coredns/plugin/etcd/msg"
"github.com/coredns/coredns/plugin/pkg/dnsutil"
"github.com/coredns/coredns/request"
@@ -37,6 +39,10 @@ func (k *Kubernetes) Federations(state request.Request, fname, fzone string) (ms
lz := node.Labels[LabelZone]
lr := node.Labels[LabelRegion]
+ if lz == "" || lr == "" {
+ return msg.Service{}, errors.New("local node missing zone/region labels")
+ }
+
if r.endpoint == "" {
return msg.Service{Host: dnsutil.Join([]string{r.service, r.namespace, fname, r.podOrSvc, lz, lr, fzone})}, nil
}