aboutsummaryrefslogtreecommitdiff
path: root/plugin/kubernetes/kubernetes_apex_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2019-01-19 11:23:13 +0000
committerGravatar GitHub <noreply@github.com> 2019-01-19 11:23:13 +0000
commit725becd134752caead1aa2b2cf3a72d01c13b599 (patch)
tree300dbfeac60f6cffd86c3aeb0b68d772415e6521 /plugin/kubernetes/kubernetes_apex_test.go
parent278303ca0df6e6167788fa3435f6ea7c6253157b (diff)
downloadcoredns-725becd134752caead1aa2b2cf3a72d01c13b599.tar.gz
coredns-725becd134752caead1aa2b2cf3a72d01c13b599.tar.zst
coredns-725becd134752caead1aa2b2cf3a72d01c13b599.zip
Stop importing testing in the main binary (#2479)
* Stop importing testing in the main binary Stop importing "testing" into the main binary: * test/helpers.go imported it; remote that and change function signature * update all tests that use this Signed-off-by: Miek Gieben <miek@miek.nl> * Drop import testing from metrics plugin Signed-off-by: Miek Gieben <miek@miek.nl> * more fiddling Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/kubernetes/kubernetes_apex_test.go')
-rw-r--r--plugin/kubernetes/kubernetes_apex_test.go6
1 files changed, 4 insertions, 2 deletions
diff --git a/plugin/kubernetes/kubernetes_apex_test.go b/plugin/kubernetes/kubernetes_apex_test.go
index 9b00658bb..9a91ea2e2 100644
--- a/plugin/kubernetes/kubernetes_apex_test.go
+++ b/plugin/kubernetes/kubernetes_apex_test.go
@@ -72,7 +72,7 @@ func TestServeDNSApex(t *testing.T) {
_, err := k.ServeDNS(ctx, w, r)
if err != tc.Error {
- t.Errorf("Test %d, expected no error, got %v\n", i, err)
+ t.Errorf("Test %d, expected no error, got %v", i, err)
return
}
if tc.Error != nil {
@@ -84,6 +84,8 @@ func TestServeDNSApex(t *testing.T) {
t.Fatalf("Test %d, got nil message and no error ford", i)
}
- test.SortAndCheck(t, resp, tc)
+ if err := test.SortAndCheck(resp, tc); err != nil {
+ t.Error(err)
+ }
}
}