aboutsummaryrefslogtreecommitdiff
path: root/internal/ui/static/js/dom_helper.js
diff options
context:
space:
mode:
authorGravatar jvoisin <julien.voisin@dustri.org> 2024-03-20 23:59:37 +0100
committerGravatar Frédéric Guillot <f@miniflux.net> 2024-03-20 17:36:01 -0700
commitbeb8c80787beadbfdb8b970368a3200f7d59f58e (patch)
tree1096a698ef89494cc58a5d81be15bc9ca56422d7 /internal/ui/static/js/dom_helper.js
parentfc4bdf3ab0088c8110905148951a26412bdef3ec (diff)
downloadv2-beb8c80787beadbfdb8b970368a3200f7d59f58e.tar.gz
v2-beb8c80787beadbfdb8b970368a3200f7d59f58e.tar.zst
v2-beb8c80787beadbfdb8b970368a3200f7d59f58e.zip
Replace a bunch of `let` with `const`
According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const > Many style guides (including MDN's) recommend using const over let whenever a variable is not reassigned in its scope. This makes the intent clear that a variable's type (or value, in the case of a primitive) can never change.
Diffstat (limited to 'internal/ui/static/js/dom_helper.js')
-rw-r--r--internal/ui/static/js/dom_helper.js10
1 files changed, 5 insertions, 5 deletions
diff --git a/internal/ui/static/js/dom_helper.js b/internal/ui/static/js/dom_helper.js
index 352d6b03..0bad0d52 100644
--- a/internal/ui/static/js/dom_helper.js
+++ b/internal/ui/static/js/dom_helper.js
@@ -4,17 +4,17 @@ class DomHelper {
}
static openNewTab(url) {
- let win = window.open("");
+ const win = window.open("");
win.opener = null;
win.location = url;
win.focus();
}
static scrollPageTo(element, evenIfOnScreen) {
- let windowScrollPosition = window.pageYOffset;
- let windowHeight = document.documentElement.clientHeight;
- let viewportPosition = windowScrollPosition + windowHeight;
- let itemBottomPosition = element.offsetTop + element.offsetHeight;
+ const windowScrollPosition = window.pageYOffset;
+ const windowHeight = document.documentElement.clientHeight;
+ const viewportPosition = windowScrollPosition + windowHeight;
+ const itemBottomPosition = element.offsetTop + element.offsetHeight;
if (evenIfOnScreen || viewportPosition - itemBottomPosition < 0 || viewportPosition - element.offsetTop > windowHeight) {
window.scrollTo(0, element.offsetTop - 10);